> -----Original Message----- > From: Ratheesh Kannoth <rkannoth@xxxxxxxxxxx> > Sent: 2024年9月23日 12:56 > To: Wei Fang <wei.fang@xxxxxxx> > Cc: Vladimir Oltean <vladimir.oltean@xxxxxxx>; davem@xxxxxxxxxxxxx; > edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; Claudiu > Manoil <claudiu.manoil@xxxxxxx>; ast@xxxxxxxxxx; daniel@xxxxxxxxxxxxx; > hawk@xxxxxxxxxx; john.fastabend@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; bpf@xxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx; > imx@xxxxxxxxxxxxxxx > Subject: Re: [PATCH net 3/3] net: enetc: reset xdp_tx_in_flight when updating > bpf program > > On 2024-09-20 at 08:42:06, Wei Fang (wei.fang@xxxxxxx) wrote: > > enetc_recycle_xdp_tx_buff() will not be called. Actually all XDP_TX > > frames are sent out and XDP_TX buffers will be freed by > enetc_free_rxtx_rings(). > why didn't you choose enetc_free_rxtx_rings() to reset inflight count to 0 ? IMO, I think enetc_reconfigure_xdp_cb() is more appropriate to reset xdp_tx_in_flight than enetc_free_rxtx_rings().
