On 2024-09-19 at 14:11:02, Wei Fang (wei.fang@xxxxxxx) wrote: > The xdp_drops statistic indicates the number of XDP frames dropped in > the Rx direction. However, enetc_xdp_drop() is also used in XDP_TX and > XDP_REDIRECT actions. If frame loss occurs in these two actions, the > frames loss count should not be included in xdp_drops, because there > are already xdp_tx_drops and xdp_redirect_failures to count the frame > loss of these two actions, so it's better to remove xdp_drops statistic > from enetc_xdp_drop() and increase xdp_drops in XDP_DROP action. nit: s/xdp_drops/xdp_rx_drops would be appropriate as you have xdp_tx_drops and xdp_redirect_failures.