On Fri, Sep 20, 2024 at 11:49:46AM +0300, Dmitry Baryshkov wrote: > On Fri, Sep 20, 2024 at 10:21:03AM GMT, Johan Hovold wrote: > > On Wed, Sep 18, 2024 at 04:02:39PM +0300, Dmitry Baryshkov wrote: > > > On X1E8 devices root ADSP domain should have tms/pdr_enabled registered. > > > Change the PDM domain data that is used for X1E80100 ADSP. > > > > Please expand the commit message so that it explains why this is > > needed and not just describes what the patch does. > > Unfortunately in this case I have no idea. It marks the domain as > restartable (?), this is what json files for CRD and T14s do. Maybe > Chris can comment more. Chris, could you help sort out if and why this change is needed? https://lore.kernel.org/all/20240918-x1e-fix-pdm-pdr-v1-1-cefc79bb33d1@xxxxxxxxxx/ > > What is the expected impact of this and is there any chance that this is > > related to some of the in-kernel pd-mapper regression I've reported > > (e.g. audio not being registered and failing with a PDR error)? > > > > https://lore.kernel.org/all/ZthVTC8dt1kSdjMb@xxxxxxxxxxxxxxxxxxxx/ > > Still debugging this, sidetracked by OSS / LPC. Johan
