Hi Greg,
On 26/08/2024 14:09, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
>
> The patch below does not apply to the 5.15-stable tree.
> If someone wants it applied there, or to any other stable or longterm
> tree, then please email the backport, including the original git commit
> id to <stable@xxxxxxxxxxxxxxx>.
Thank you for the notification!
(...)
> ------------------ original commit in Linus's tree ------------------
>
> From 65fb58afa341ad68e71e5c4d816b407e6a683a66 Mon Sep 17 00:00:00 2001
> From: "Matthieu Baerts (NGI0)" <matttbe@xxxxxxxxxx>
> Date: Mon, 19 Aug 2024 21:45:22 +0200
> Subject: [PATCH] selftests: mptcp: join: check re-using ID of closed subflow
>
> This test extends "delete and re-add" to validate the previous commit. A
> new 'subflow' endpoint is added, but the subflow request will be
> rejected. The result is that no subflow will be established from this
> address.
>
> Later, the endpoint is removed and re-added after having cleared the
> firewall rule. Before the previous commit, the client would not have
> been able to create this new subflow.
>
> While at it, extra checks have been added to validate the expected
> numbers of MPJ and RM_ADDR.
>
> The 'Fixes' tag here below is the same as the one from the previous
> commit: this patch here is not fixing anything wrong in the selftests,
> but it validates the previous fix for an issue introduced by this commit
> ID.
>
> Fixes: b6c08380860b ("mptcp: remove addr and subflow in PM netlink")
As mentioned above, the 'Fixes' tag here is pointing at the issue in the
code, but the test file cannot easily be patched to validate the issue.
That's OK, some CI will use the selftests from the latest stable kernel.
No need to worry about that one for v5.15.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
