[Public] > -----Original Message----- > From: Jiri Slaby <jirislaby@xxxxxxxxxx> > Sent: Tuesday, August 20, 2024 12:39 AM > To: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx>; stable@xxxxxxxxxxxxxxx > Cc: patches@xxxxxxxxxxxxxxx; Sasha Levin <sashal@xxxxxxxxxx>; Koenig, > Christian <Christian.Koenig@xxxxxxx>; Pan, Xinhui <Xinhui.Pan@xxxxxxx>; > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 6.10 090/263] drm/amdgpu/pm: Fix the param type of > set_power_profile_mode > > On 19. 08. 24, 22:12, Deucher, Alexander wrote: > > [Public] > > > >> -----Original Message----- > >> From: Jiri Slaby <jirislaby@xxxxxxxxxx> > >> Sent: Monday, August 19, 2024 3:54 AM > >> To: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; > >> stable@xxxxxxxxxxxxxxx > >> Cc: patches@xxxxxxxxxxxxxxx; Deucher, Alexander > >> <Alexander.Deucher@xxxxxxx>; Sasha Levin <sashal@xxxxxxxxxx>; Koenig, > >> Christian <Christian.Koenig@xxxxxxx>; Pan, Xinhui > >> <Xinhui.Pan@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx > >> Subject: Re: [PATCH 6.10 090/263] drm/amdgpu/pm: Fix the param type > >> of set_power_profile_mode > >> > >> FTR: > >> Delivery has failed to these recipients or groups: > >> Ma Jun (Jun.Ma2@xxxxxxx) > >> The email address you entered couldn't be found > >> > >> So the author of the patch CANNOT respond. Anyone else? > > > > This was a Coverity fix. As to why it was pulled into stable, I think Sasha's > scripts picked it up. > > Sorry, but again, why do we change the kernel to _silence_ Coverity? We do > not do this even for compilers. > > I am asking, why do you call this a fix at all? What does it fixes? I don't think this is stable material. As I said, it got picked up by a script that nominates patches for stable. I guess more people need to review the patches that get nominated for stable. I personally can't keep up with all of them. Alex > > And finally, Coverity has a "False positive" selection box to dismiss a warning > for good. One needs not changing the code. > > thanks, > -- > js > suse labs
