On Tue, 20 Aug 2024 08:54:01 +0100, Ma Ke <make24@xxxxxxxxxxx> wrote: > > Add the missing of_node_put() to release the refcount incremented > by of_find_matching_node(). This doesn't reflect the patch anymore. Something like this should be closer to reality: "We fail to perform an of_node_put() when of_address_to_resource() fails, leading to a refcount leak. Address this by moving the error handling path outside of the loop and making it common to all failure modes." With the commit message fixed: Reviewed-by: Marc Zyngier <maz@xxxxxxxxxx> M. -- Without deviation from the norm, progress is not possible.