Hi Umang,
Thank you for the patch.
On Mon, Jul 29, 2024 at 04:34:36PM +0530, Umang Jain wrote:
> Mention the reset-gpio polarity in the device tree bindings.
> It is GPIO_ACTIVE_LOW according to the datasheet.
>
> Signed-off-by: Umang Jain <umang.jain@xxxxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml
> index 106c36ee966d..fb4c9d42ed1c 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml
> @@ -92,6 +92,8 @@ examples:
> ovdd-supply = <&camera_vddo_1v8>;
> dvdd-supply = <&camera_vddd_1v2>;
>
> + reset-gpios = <&gpio 50 GPIO_ACTIVE_LOW>;
> +
I think it's good to include this in the example, but it doesn't match
the commit message. I was expecting to see a change to the binding
rules, not to the example.
> port {
> imx335: endpoint {
> remote-endpoint = <&cam>;
--
Regards,
Laurent Pinchart
