On Mon, Jun 24, 2024 at 07:54:45PM +0800, joeyli wrote: > On Mon, Jun 24, 2024 at 01:43:25PM +0200, Markus Elfring wrote: > > >>> … So they should also use dev_hold() to increase the > > >>> refcnt of skb->dev. > > >> … > > >> > > >> reference counter of “skb->dev”? > > > > > > Yes, I will update my wording. > > > > Would you like to improve such a change description also with imperative wordings? > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc4#n94 > > > > > > How do you think about the text “Prevent use-after-free issues at more places” > > for a summary phrase? > > > > Thanks for your suggestion. I will update the wording in next version. Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who are actively working to produce patches and features with comments that, in the end, are a waste of time. Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them. thanks, greg k-h's patch email bot