Hi Wentong, On Mon, Jun 24, 2024 at 09:42:20AM +0800, Wentong Wu wrote: > Constructing the SPI transfer command as per the specific request. > > Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device") > Cc: stable@xxxxxxxxxxxxxxx # for 6.8+ > Signed-off-by: Wentong Wu <wentong.wu@xxxxxxxxx> > Tested-by: Jason Chen <jason.z.chen@xxxxxxxxx> > --- > drivers/misc/mei/vsc-tp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c > index 5f3195636e53..fed156919fda 100644 > --- a/drivers/misc/mei/vsc-tp.c > +++ b/drivers/misc/mei/vsc-tp.c > @@ -331,7 +331,7 @@ int vsc_tp_rom_xfer(struct vsc_tp *tp, const void *obuf, void *ibuf, size_t len) > return ret; > } > > - ret = vsc_tp_dev_xfer(tp, tp->tx_buf, tp->rx_buf, len); > + ret = vsc_tp_dev_xfer(tp, tp->tx_buf, ibuf ? tp->rx_buf : ibuf, len); The latter ibuf should be NULL explicitly. > if (ret) > return ret; > -- Kind regards, Sakari Ailus