Re: Patch "netfilter: Remove the now superfluous sentinel elements from ctl_table array" has been added to the 6.6-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 22, 2024 at 07:45:37PM -0400, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
> 
>     netfilter: Remove the now superfluous sentinel elements from ctl_table array
> 
> to the 6.6-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      netfilter-remove-the-now-superfluous-sentinel-elemen.patch
> and it can be found in the queue-6.6 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@xxxxxxxxxxxxxxx> know about it.

I don't understand why we are putting these in stable. IMO, they should
not go there and this is why:

1. This is not a fix.
   The main motivation for doing these sentinel removals is to avoid
   bloat in the boot and compiled image (read more in cover letters for
   [1,2,3,4,5,6]) in future kernel versions. This makes no sense in
   stable IMO.

2. There are lots of moving parts and no "bang for the buck"
   If you are going to bring one of them, you need to bring all of them.
   This means brining in the preparation [7], the intermediate
   [1,2,3,4,5,6] and the final patch [8]. This is not only prone to
   error, but there is no real reason to do that in stable.

If I'm missing something, please let me know.

Best

Joel

[1] https://git.kernel.org/pub/scm/linux/kernel/git/joel.granados/linux.git/log/?h=archive/remsent_net
[2] https://git.kernel.org/pub/scm/linux/kernel/git/joel.granados/linux.git/log/?h=archive/remsent_kernel
[3] https://git.kernel.org/pub/scm/linux/kernel/git/joel.granados/linux.git/log/?h=archive/remsent_misc
[4] https://git.kernel.org/pub/scm/linux/kernel/git/joel.granados/linux.git/log/?h=archive/remsent_fs
[5] https://git.kernel.org/pub/scm/linux/kernel/git/joel.granados/linux.git/log/?h=archive/remsent_driver
[6] https://git.kernel.org/pub/scm/linux/kernel/git/joel.granados/linux.git/log/?h=archive/remsent_arch
[7] https://lore.kernel.org/20230731071728.3493794-1-j.granados@xxxxxxxxxxx
[8] https://lore.kernel.org/20240604-jag-sysctl_remset-v1-0-2df7ecdba0bd@xxxxxxxxxxx





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux