On Wed, May 29, 2024 at 03:59:31PM +0800, shaozhengchao wrote: > > > On 2024/5/25 18:42, Greg KH wrote: > > On Sat, May 25, 2024 at 06:21:08PM +0800, shaozhengchao wrote: > > > > > > > > > On 2024/5/25 17:42, Greg KH wrote: > > > > On Sat, May 25, 2024 at 05:33:00PM +0800, shaozhengchao wrote: > > > > > > > > > > > > > > > On 2024/5/23 19:34, Greg KH wrote: > > > > > > On Mon, May 06, 2024 at 11:05:52AM +0800, Zhengchao Shao wrote: > > > > > > > There's no "pernet" variable in the struct hashinfo. The "pernet" variable > > > > > > > is introduced from v6.1-rc1. Revert pre-patch and post-patch. > > > > > > > > > > > > I do not understand, why are these reverts needed? > > > > > > > > > > > > How does the code currently build if there is no variable here? > > > > > > > > > > > > confused, > > > > > > > > > > > > greg k-h > > > > > Hi greg: > > > > > If only the first patch is merged, compilation will fail. > > > > > There's no "pernet" variable in the struct hashinfo. > > > > > > > > But both patches are merged together here. Does the released kernel > > > > versions fail to build somehow? > > > > > > > > thanks, > > > > > > > > greg k-h > > > > > > > Work well, as I know. > > > > Ok, then why send these reverts? Are they needed, or are they not > > needed? And if needed, why? > > > > still confused, > > > > greg k-h > > > Hi greg: > If the patchset is merged together, and the compilation is normal. I'm > just concerned that some people only put in one of the patchset and forget > to put in both of them, which will be a problem. That's not our responsibility at all. There is a reason we do releases, not just individual commits. We test and release changes all at the same time, and so, you should just take them all please. Otherwise you are on your own and usually end up with a broken system. good luck! greg k-h
