On 5/15/24 09:58, Guenter Roeck wrote:
On 5/15/24 09:20, Linus Torvalds wrote:
On Wed, 15 May 2024 at 09:17, Mark Brown <broonie@xxxxxxxxxx> wrote:
A bisect claims that "net: bcmgenet:
synchronize EXT_RGMII_OOB_CTRL access" is the first commit that breaks,
I'm not seeing issues with other stables.
That's d85cf67a3396 ("net: bcmgenet: synchronize EXT_RGMII_OOB_CTRL
access") upstream. Is upstream ok?
Upstream code was rearranged. d85cf67a3396 affects bcmgenet_mii_config().
3443d6c3616b affects bcmgenet_mac_config(). bcmgenet_mac_config()
is called from bcmgenet_phy_pause_set() under phydev->lock. I would guess
that trying to acquire the same lock in in bcmgenet_mac_config() results
in a deadlock.
Yes that's exactly what is happening:
https://lore.kernel.org/all/d52e7e4a-2b60-4fdf-9006-12528a91dabf@xxxxxxxxxxxx/
Thanks!
--
Florian
