Re: [PATCH] ARM: dts: imx51-babbage: Fix ULPI PHY reset modelling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Dienstag, den 06.01.2015, 11:59 -0200 schrieb Fabio Estevam:
> On Tue, Jan 6, 2015 at 11:54 AM, Lucas Stach <l.stach@xxxxxxxxxxxxxx> wrote:
> 
> >> Actually the ULPI PHY reset is properly handled now. What is missing
> >> is the USB Hub reset to be properly handled.
> >>
> > No it is not. A regulator isn't the proper abstraction for a reset at
> > all. Even if you (ab)use the regulator drivers ability to toggle a reset
> > GPIO.
> > A ULPI PHY reset needs to be modeled as a GPIO reset attached to USB
> > controller node. There is no other way to describe the hardware
> > accurately.
> 
> The ULPI PHY is modelled as a GPIO reset via reset-gpios property.
> This is documented at
> Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt:
> 
> - reset-gpios: Should specify the GPIO for reset.
> 
> This is the property we use right now for resetting the ULPI PHY.

Right. I misread that part of the patch. Sorry about that.

Regards,
Lucas 

-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |

--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]