Am Dienstag, den 06.01.2015, 11:47 -0200 schrieb Fabio Estevam: > On Tue, Jan 6, 2015 at 11:36 AM, Lucas Stach <l.stach@xxxxxxxxxxxxxx> wrote: > > > For the record: > > I'm not happy with this patch. It still abuses the regulator API for > > something completely unrelated and this may well break again in the > > future. But given that it fixes an actual regression and you already > > sent a pull including this I'm okay to keep it. > > > > We still need a proper fix to handle ULPI resets to get rid of this > > hackery. > > Actually the ULPI PHY reset is properly handled now. What is missing > is the USB Hub reset to be properly handled. > No it is not. A regulator isn't the proper abstraction for a reset at all. Even if you (ab)use the regulator drivers ability to toggle a reset GPIO. A ULPI PHY reset needs to be modeled as a GPIO reset attached to USB controller node. There is no other way to describe the hardware accurately. Regards, Lucas -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html