Il 30/04/24 16:24, Matthias Brugger ha scritto:
On 4/28/24 13:24, Sasha Levin wrote:
This is a note to let you know that I've just added the patch titled
arm64: dts: mediatek: mt7622: drop "reset-names" from thermal block
to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
arm64-dts-mediatek-mt7622-drop-reset-names-from-ther.patch
and it can be found in the queue-4.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
commit 9628765c4a0eefa9474ef4a0698691a10395a469
Author: Rafał Miłecki <rafal@xxxxxxxxxx>
Date: Sun Mar 17 23:10:50 2024 +0100
arm64: dts: mediatek: mt7622: drop "reset-names" from thermal block
[ Upstream commit ecb5b0034f5bcc35003b4b965cf50c6e98316e79 ]
Binding doesn't specify "reset-names" property and Linux driver also
doesn't use it.
I think that's an open discussion item if fixes to DTS checks are valid stable
backports. From my point of view there is no bug so it shouldn't be in stable.
The only benefit apart from one less warning is a few bytes less in a *.dtb file...
I don't feel like I agree with you, but at the same time I also don't feel like
disagreeing - as those are not "fixing practical issues" in the end.
Passing the word to devicetree/bindings maintainers... :-)
Cheers,
Angelo
Regards,
Matthias
Fix following validation error:
arch/arm64/boot/dts/mediatek/mt7622-rfb1.dtb: thermal@1100b000: Unevaluated
properties are not allowed ('reset-names' was unexpected)
from schema $id:
http://devicetree.org/schemas/thermal/mediatek,thermal.yaml#
Fixes: ae457b7679c4 ("arm64: dts: mt7622: add SoC and peripheral related
device nodes")
Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>
Reviewed-by: AngeloGioacchino Del Regno
<angelogioacchino.delregno@xxxxxxxxxxxxx>
Link: https://lore.kernel.org/r/20240317221050.18595-5-zajec5@xxxxxxxxx
Signed-off-by: AngeloGioacchino Del Regno
<angelogioacchino.delregno@xxxxxxxxxxxxx>
Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
index 76297dac2d459..f8df34ac1e64d 100644
--- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
@@ -459,7 +459,6 @@ thermal: thermal@1100b000 {
<&pericfg CLK_PERI_AUXADC_PD>;
clock-names = "therm", "auxadc";
resets = <&pericfg MT7622_PERI_THERM_SW_RST>;
- reset-names = "therm";
mediatek,auxadc = <&auxadc>;
mediatek,apmixedsys = <&apmixedsys>;
nvmem-cells = <&thermal_calibration>;
