Re: Patch "arm64: dts: mediatek: mt7622: fix ethernet controller "compatible"" has been added to the 4.19-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 4/28/24 13:24, Sasha Levin wrote:
This is a note to let you know that I've just added the patch titled

     arm64: dts: mediatek: mt7622: fix ethernet controller "compatible"

to the 4.19-stable tree which can be found at:
     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
      arm64-dts-mediatek-mt7622-fix-ethernet-controller-co.patch
and it can be found in the queue-4.19 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit b6f34784d92ba280c8a4f42e22fee3c41cd09c3f
Author: Rafał Miłecki <rafal@xxxxxxxxxx>
Date:   Sun Mar 17 23:10:49 2024 +0100

     arm64: dts: mediatek: mt7622: fix ethernet controller "compatible"
[ Upstream commit 208add29ce5b7291f6c466e4dfd9cbf61c72888e ] Fix following validation error:
     arch/arm64/boot/dts/mediatek/mt7622-rfb1.dtb: ethernet@1b100000: compatible: ['mediatek,mt7622-eth', 'mediatek,mt2701-eth', 'syscon'] is too long
             from schema $id: http://devicetree.org/schemas/net/mediatek,net.yaml#
     (and other complains about wrong clocks).

DTS validation fix, not a real bug. From my point of view it shouldn't be in stable. I won't go on in the list, I would like to hear from others how serious they see it. With my distro hat on, this kind of stable fixes are not helpfull to make a code base stable (as there is no stability issue).

Matthias

     Fixes: 5f599b3a0bb8 ("arm64: dts: mt7622: add ethernet device nodes")
     Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>
     Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
     Link: https://lore.kernel.org/r/20240317221050.18595-4-zajec5@xxxxxxxxx
     Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
     Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
index 5c12e9dad9167..76297dac2d459 100644
--- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
@@ -846,9 +846,7 @@ hsdma: dma-controller@1b007000 {
  	};
eth: ethernet@1b100000 {
-		compatible = "mediatek,mt7622-eth",
-			     "mediatek,mt2701-eth",
-			     "syscon";
+		compatible = "mediatek,mt7622-eth";
  		reg = <0 0x1b100000 0 0x20000>;
  		interrupts = <GIC_SPI 223 IRQ_TYPE_LEVEL_LOW>,
  			     <GIC_SPI 224 IRQ_TYPE_LEVEL_LOW>,




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux