On Mon, Feb 26, 2024 at 11:42:49PM +0800, Shengyu Qu wrote: > Hi Andrew, > > So I should describe in commit message that user should set the stick to > 2.5g/automatic mode and include the link in previous mail? Is that enough? As Russell pointed out, this sounds racy. We need lots of details in the commit message to convince us this is safe, and is not going to cause a regression. If it does break and cause a regression, having those details will also help us decide what to do, other than just revert the change. The further the devices get from well defined standardised behaviour, the more details are needed. Andrew