Re: [PATCH v2 06/34] iser-target: Introduce state ISER_CONN_FULL_FEATURE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg & Co,

On Mon, 2014-12-01 at 17:30 -0800, Greg KH wrote:
> On Mon, Dec 01, 2014 at 07:49:56PM +0200, Sagi Grimberg wrote:
> > ISER_CONN_UP state is not sufficient to know if
> > we should wait for completion of flush errors and
> > disconnected_handler event.
> > 
> > Instead, split it to 2 states:
> > - ISER_CONN_UP: Got to CM connected phase, This state
> > indicates that we need to wait for a CM disconnect
> > event before going to teardown.
> > 
> > - ISER_CONN_FULL_FEATURE: Got to full feature phase
> > after we posted login response, This state indicates
> > that we posted recv buffers and we need to wait for
> > flush completions before going to teardown.
> > 
> > Cc: <stable@xxxxxxxxxxxxxxx> # 3.10+
> > Signed-off-by: Sagi Grimberg <sagig@xxxxxxxxxxxx>
> > ---
> >  drivers/infiniband/ulp/isert/ib_isert.c |   29 ++++++++++++++++++++++++-----
> >  drivers/infiniband/ulp/isert/ib_isert.h |    1 +
> >  2 files changed, 25 insertions(+), 5 deletions(-)
> 
> Any reason you sent out 3 copies of this patch series?
> 

Apologies, I asked Sagi to include some pointers for me as to which
patches need to be considered for stable.

Sagi, in the future please add extra info about stable CCs into the
cover-letter instead of using commit tags, and I'll add them in when
merging.

> And please go read Documentation/stable_kernel_rules.txt, I don't think
> many of these patches in this series are actually relevant for stable
> kernels.
> 

The end result of the patches marked as stable here is to address a
number of outstanding issues with active I/O shutdown, especially with
large numbers of active sessions + RDMA ports.

To that end, they will need to be squashed + add more detailed commit
log context to explain what's going on.

Thank you,

--nab

--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]