On 16.01.24 16:54, David Sterba wrote: > > I don't know if we should warn here at all, the warning is there since > 2015 and only now we see it triggered, I guess everybody sane using the > discard interface uses proper values. Warning level means that it needs > user attention that something is wrong and take some action or examine > the system. > > The discard range could be verified at the beginning of the ioctl, but > printing it here is a bit late. I've checked xfs and it silently rounds > down the start and offset the same way, I find this sufficient thing to > do. > Yeah thenm lets do it this way, Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>
