> > > So Greg, how we move forward with this one? Keep the revert or > > > integrate Leo's work on top of Johannes'? > > > > It would be "resend with the fixes rolled in as a new backport". > > No, the new change needs to be a seprate commit. Oh, I stand corrected. I thought you said earlier you'd prefer a new, fixed, backport of the change that was meant to fix CQM but broke the locking, rather than two new commits. > > > Johannes, how important is your fix for the stable 6.x kernels when > > > done properly? > > > > Well CQM was broken completely for anything but (effectively) brcmfmac ... > That means roaming decisions will be less optimal, mostly. > > > > Is that annoying? Probably. Super critical? I guess not. > > Is it a regression or was it always like this? It was a regression. johannes -- Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928