>From da1e023a39987c1bc2d5b27ecf659d61d9a4724c Mon Sep 17 00:00:00 2001 From: foolishhart <62256078+foolishhart@xxxxxxxxxxxxxxxxxxxxxxxx> Date: Mon, 27 Nov 2023 11:51:04 +0000 Subject: [PATCH] Update acp6x-mach.c Added ASUSTeK COMPUTER INC "E1504FA" to quirks file to enable microphone array on ASUS Vivobook GO 15. --- sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 15a864dcd7bd3a..3babb17a56bb55 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -283,6 +283,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "M6500RC"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "E1504FA"), + } + }, { .driver_data = &acp6x_card, .matches = { Signed-off-by: Malcolm Hart <malcolm@xxxxxxxxxx> Mario Limonciello <mario.limonciello@xxxxxxx> writes: > On 11/27/2023 09:23, Malcolm Hart wrote: >> From da1e023a39987c1bc2d5b27ecf659d61d9a4724c Mon Sep 17 00:00:00 >> 2001 >> From: foolishhart <62256078+foolishhart@xxxxxxxxxxxxxxxxxxxxxxxx> >> Date: Mon, 27 Nov 2023 11:51:04 +0000 >> Subject: [PATCH] Update acp6x-mach.c >> Added ASUSTeK COMPUTER INC "E1504FA" to quirks file to >> enable microphone array on ASUS Vivobook GO 15. > > You're missing a Signed-off-by: tag. > Also as this should be going to stable you should have a tag for: > > Cc: stable@xxxxxxxxxxxxxxx > >> --- >> sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> diff --git a/sound/soc/amd/yc/acp6x-mach.c >> b/sound/soc/amd/yc/acp6x-mach.c >> index 15a864dcd7bd3a..3babb17a56bb55 100644 >> --- a/sound/soc/amd/yc/acp6x-mach.c >> +++ b/sound/soc/amd/yc/acp6x-mach.c >> @@ -283,6 +283,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { >> DMI_MATCH(DMI_PRODUCT_NAME, "M6500RC"), >> } >> }, >> + { >> + .driver_data = &acp6x_card, >> + .matches = { >> + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."), >> + DMI_MATCH(DMI_PRODUCT_NAME, "E1504FA"), >> + } >> + }, >> { >> .driver_data = &acp6x_card, >> .matches = { >> Mark Brown <broonie@xxxxxxxxxx> writes: >> >>> [[PGP Signed Part:Undecided]] >>> On Mon, Nov 27, 2023 at 12:24:59PM +0000, Malcolm Hart wrote: >>>> Like other ASUS models the Asus Vivobook E1504FA requires an entry in >>>> the quirk list to enable the internal microphone. >>>> >>>> Showing >>>> with 7 additions and 0 deletions. >>>> 7 changes: 7 additions & 0 deletions 7 >>>> sound/soc/amd/yc/acp6x-mach.c >>>> @@ -283,6 +283,13 @@ static const struct dmi_system_id >>>> yc_acp_quirk_table[] = { >>> >>> The patch appears to have been unusably corrupted by your e-mail >>> software and is also missing a Signed-off-by. See email-cleints.rst for >>> some suggestions on configuring things, or it might be worth looking >>> into b4 and it's web submission endpoint: >>> >>> https://b4.docs.kernel.org/en/latest/ >>> >>> [[End of PGP Signed Part]] >>