Re: FAILED: patch "[PATCH] mtd: m25p80,spi-nor: Fix module aliases for m25p80" failed to apply to 3.17-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 12, 2014 at 04:26:47AM +0900, Greg Kroah-Hartman wrote:
> On Tue, Nov 11, 2014 at 05:08:25PM +0000, Ben Hutchings wrote:
> > On Tue, 2014-11-11 at 14:17 +0900, Greg KH wrote:
> > > On Mon, Nov 10, 2014 at 03:53:49PM -0800, Brian Norris wrote:
> > > > On Mon, Nov 10, 2014 at 01:34:24PM +0900, Greg Kroah-Hartman wrote:
> > > > > The patch below does not apply to the 3.17-stable tree.
> > > > > If someone wants it applied there, or to any other stable or longterm
> > > > > tree, then please email the backport, including the original git commit
> > > > > id to <stable@xxxxxxxxxxxxxxx>.
> > > > 
> > > > Did you follow the annotations in the commit message? The Canonical-run
> > > > 3.16.x stable seemed to pick them up just fine. Or did I get the syntax
> > > > wrong? (I still owe you an update to
> > > > Documentation/stable-kernel-rules.txt, by the way.)
> > > > 
> > > > > ------------------ original commit in Linus's tree ------------------
> > > > > 
> > > > > From a5b7616c55e188fe3d6ef686bef402d4703ecb62 Mon Sep 17 00:00:00 2001
> > > > ...
> > > > > Fixes: 03e296f613af ("mtd: m25p80: use the SPI nor framework")
> > > > > Cc: <stable@xxxxxxxxxxxxxxx> # 3.16.x: 32f1b7c8352f: mtd: move support for struct flash_platform_data into m25p80
> > > > > Cc: <stable@xxxxxxxxxxxxxxx> # 3.16.x: 90e55b3812a1: mtd: m25p80: get rid of spi_get_device_id
> > > > > Cc: <stable@xxxxxxxxxxxxxxx> # 3.16.x: 70f3ce0510af: mtd: spi-nor: make spi_nor_scan() take a chip type name, not spi_device_id
> > > > > Cc: <stable@xxxxxxxxxxxxxxx> # 3.16.x
> > > > 
> > > > I am able to successfully checkout your linux-3.17.y and:
> > > > 
> > > > git cherry-pick 32f1b7c8352f
> > > > git cherry-pick 90e55b3812a1
> > > > git cherry-pick 70f3ce0510af
> > > > git cherry-pick a5b7616c55e1
> > > 
> > > That all seems to be a ton of churn for a stable kernel patch,
> > > especially something as "simple" as a module alias, don't you agree?
> > > That's why I wouldn't apply all of those patches, sorry.
> > 
> > Unfortunately there isn't a really tiny fix for this.  And I think
> > losing all the module aliases is a pretty serious regression.
> 
> It's not much of a regression if it hasn't worked since 3.16-rc1...

Two things:

 (1) MTD users are typically embedded and may not always test the latest
     mainline

 (2) This driver is often used built-in, not as a module, so most users
     wouldn't notice

Brian
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]