On 28/08/2023 18:17, Laurent Pinchart wrote:
vfe-480 is copied from vfe-17x and has the same racy idle timeout bug as in
17x.
Fix the vfe_disable_output() logic to no longer be racy and to conform
to the 17x way of quiescing and then resetting the VFE.
How about dropping the duplicate function and share a single
implementation for the two files ?
Hmm, so I looked at this.
In principle I like it. Right now vfe-170 only deals with a single
write-master = 0, whereas vfe-480 deals with multiple write-masters.
Collapsing down into one place is the right thing to do however, it
feels like a larger update to vfe-170 that merits its own series along
the lines of "Support multiple write-masters for vfe-17x" or better
still "Support virtual channels for vfe-17x" which is what is implied by
this.
Yet another thing to add to the TODO list here.
---
bod
