On Mon, 2014-11-03 at 10:10 -0800, Kamal Mostafa wrote:
[...]
> But hold up... That one 558e473 ("before completing previous QR_EC")
> gets reverted by df9ff91 in v3.18-rc3.
>
> Considering:
>
> 558e473 ACPI / EC: Add support to disallow QR_EC to be issued before completing previous QR_EC
> 3afcf2e ACPI / EC: Add support to disallow QR_EC to be issued when SCI_EVT isn't set
> df9ff91 Revert "ACPI / EC: Add support to disallow QR_EC to be issued before completing previous QR_EC"
> 7914900 ACPI / EC: Fix regression due to conflicting firmware behavior between Samsung and Acer.
>
> I think the right actions are:
>
> a. stable trees should not merge 558e473 ("before completing previous
> QR_EC") if they haven't already, and should revert it if they have
> already.
>
> b. stable trees* should merge 3afcf2e ("when SCI_EVT isn't set") and its
> follow-up fix 7914900.
>
> c. stable trees* should merge 7934900 as a follow-up fix to 3afcf2e.
>
> *at least all stable trees which carry this one, which 3afcf2e fixes:
> c0d6534 ACPI / EC: Fix race condition in ec_transaction_completed()
>
> Lv, can you confirm that, or provide other guidance?
[...]
This makes sense to me, but I'd also like to hear what Lv says.
Ben.
--
Ben Hutchings
The program is absolutely right; therefore, the computer must be wrong.
Attachment:
signature.asc
Description: This is a digitally signed message part