On Mon, 2014-11-03 at 13:43 +0000, Ben Hutchings wrote: > On Mon, 2014-11-03 at 11:27 +0100, Jiri Slaby wrote: > > On 11/01/2014, 02:29 AM, Ben Hutchings wrote: > > > On Wed, 2014-09-24 at 08:13 +0000, Zheng, Lv wrote: > > >> Hi, Greg and Alexander > > >> > > >>> From: Alexander Mezin [mailto:mezin.alexander@xxxxxxxxx] Sent: > > >>> Sunday, September 14, 2014 11:32 PM > > >>> > > >>> I think this patch together with > > >>> "acpi-ec-add-support-to-disallow-qr_ec-to-be-issued-before-completing-previous-qr_ec.patch" > > >>> > > >>> > > should be added to 3.14 too. > > >>> > > >>> The problem is present in 3.14 since 3.14.13. And, if I > > >>> remember correctly, these patches apply cleanly to 3.14.18. > > >> > > >> According to my mail queue. It seems the original EC race fix > > >> that triggered the hidden bug has been back ported to the > > >> following kernels: 3.14-stable/3.15-stable. > > >> > > >> And the following kernels by other maintainers. 3.13.11.6 -stable > > >> by Kamal Mostafa 3.2.62-rc1 by Ben Hutchings 3.11.10.14 -stable > > >> by Luis Henriques 3.12 stable by Jiri Slaby So let me have them > > >> informed. > > > [...] > > > > > > I already included this patch ("ACPI / EC: Add support to disallow > > > QR_EC to be issued when SCI_EVT isn't set") in 3.2.63, so is there > > > anything else I need to do? > > > > I believe the other: > > commit 558e4736f2e1b0e6323adf7a5e4df77ed6cfc1a4 > > Author: Lv Zheng <lv.zheng@xxxxxxxxx> > > Date: Thu Aug 21 14:41:26 2014 +0800 > > > > ACPI / EC: Add support to disallow QR_EC to be issued before > > completing previous QR_EC > > > > I am taking both to 3.12 now. Thanks. > > Thanks, I'll apply this to 3.2 (either this or the next update). > > Ben. But hold up... That one 558e473 ("before completing previous QR_EC") gets reverted by df9ff91 in v3.18-rc3. Considering: 558e473 ACPI / EC: Add support to disallow QR_EC to be issued before completing previous QR_EC 3afcf2e ACPI / EC: Add support to disallow QR_EC to be issued when SCI_EVT isn't set df9ff91 Revert "ACPI / EC: Add support to disallow QR_EC to be issued before completing previous QR_EC" 7914900 ACPI / EC: Fix regression due to conflicting firmware behavior between Samsung and Acer. I think the right actions are: a. stable trees should not merge 558e473 ("before completing previous QR_EC") if they haven't already, and should revert it if they have already. b. stable trees* should merge 3afcf2e ("when SCI_EVT isn't set") and its follow-up fix 7914900. c. stable trees* should merge 7934900 as a follow-up fix to 3afcf2e. *at least all stable trees which carry this one, which 3afcf2e fixes: c0d6534 ACPI / EC: Fix race condition in ec_transaction_completed() Lv, can you confirm that, or provide other guidance? Thanks, -Kamal -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html