On 10/31/2014, 12:53 AM, Florian Westphal wrote:
> Jiri Slaby <jslaby@xxxxxxx> wrote:
>> From: Florian Westphal <fw@xxxxxxxxx>
>>
>> This patch has been added to the 3.12 stable tree. If you have any
>> objections, please let us know.
>
> Objection.
>
> 3.12 misses f87c10a8aa ('ipv4: introduce ip_dst_mtu_maybe_forward and
> protect forwarding path against pmtu spoofing'), so
>
>> + /* common case: locally created skb or seglen is <= mtu */
>> + if (((IPCB(skb)->flags & IPSKB_FORWARDED) == 0) ||
>
> IPSKB_FORWARDED is not set for forwarded packets and the check always
> true.
Oh, thanks for spotting.
> I recommend to revert fe6cc55f3a9a ('net: ip, ipv6: handle gso skbs in
> forwarding path'), its 91e97e5763b4f0425ad90df39a23cdbd72671a7e in
> 3.12.y tree instead.
But what about the ones below, which "Fixes fe6cc55" too? I am not sure
I want to revert all those. What are the consequences, if I skip only
this one (net: ip: push gso skb forwarding handling down the stack), please?
==>
pokus/3387-net-ip-push-gso-skb-forwarding-handling-down-the-sta.patch <==
>From e465fe7e48d14eb80e7b566c4542a16fd7a0c27d Mon Sep 17 00:00:00 2001
From: Florian Westphal <fw@xxxxxxxxx>
Date: Mon, 5 May 2014 15:00:43 +0200
Subject: [PATCH 3387/3496] net: ip: push gso skb forwarding handling
down the
stack
==> pokus/1250-net-ip-ipv6-handle-gso-skbs-in-forwarding-path.patch <==
>From 91e97e5763b4f0425ad90df39a23cdbd72671a7e Mon Sep 17 00:00:00 2001
From: Florian Westphal <fw@xxxxxxxxx>
Date: Sat, 22 Feb 2014 10:28:31 +0100
Subject: [PATCH 1250/3496] net: ip, ipv6: handle gso skbs in forwarding path
commit fe6cc55f3a9a053482a76f5a6b2257cee51b4663 upstream.
==>
pokus/2013-net-core-don-t-account-for-udp-header-size-when-comp.patch <==
>From 6a80e19b4cc257a0291920157a6c1749e138e268 Mon Sep 17 00:00:00 2001
From: Florian Westphal <fw@xxxxxxxxx>
Date: Wed, 9 Apr 2014 10:28:50 +0200
Subject: [PATCH 2013/3496] net: core: don't account for udp header size when
computing seglen
==>
pokus/2045-net-ipv6-send-pkttoobig-immediately-if-orig-frag-siz.patch <==
>From 156439bd5ca8f99ad08e12723a5f687719815b33 Mon Sep 17 00:00:00 2001
From: Florian Westphal <fw@xxxxxxxxx>
Date: Mon, 5 May 2014 00:03:34 +0200
Subject: [PATCH 2045/3496] net: ipv6: send pkttoobig immediately if orig
frag
size > mtu
==> pokus/2044-net-ipv4-ip_forward-fix-inverted-local_df-test.patch <==
>From b2b68efab92145a73420d86a2956fec786eda078 Mon Sep 17 00:00:00 2001
From: Florian Westphal <fw@xxxxxxxxx>
Date: Sun, 4 May 2014 23:24:31 +0200
Subject: [PATCH 2044/3496] net: ipv4: ip_forward: fix inverted local_df test
[ Upstream commit ca6c5d4ad216d5942ae544bbf02503041bd802aa ]
thanks,
--
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html