Re: [patch added to the 3.12 stable tree] net: ip: push gso skb forwarding handling down the stack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jiri Slaby <jslaby@xxxxxxx> wrote:
> From: Florian Westphal <fw@xxxxxxxxx>
> 
> This patch has been added to the 3.12 stable tree. If you have any
> objections, please let us know.

Objection.

3.12 misses f87c10a8aa ('ipv4: introduce ip_dst_mtu_maybe_forward and
protect forwarding path against pmtu spoofing'), so

> +	/* common case: locally created skb or seglen is <= mtu */
> +	if (((IPCB(skb)->flags & IPSKB_FORWARDED) == 0) ||

IPSKB_FORWARDED is not set for forwarded packets and the check always
true.

I recommend to revert  fe6cc55f3a9a ('net: ip, ipv6: handle gso skbs in
forwarding path'), its 91e97e5763b4f0425ad90df39a23cdbd72671a7e in
3.12.y tree instead.
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]