Re: [PATCH net 5/6] net: hns3: fix wrong print link down up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




on 2023/7/30 2:23, Andrew Lunn wrote:
     Now i wounder if you are fixing the wrong thing. Maybe you should be
     fixing the PHY so it does not report up and then down? You say 'very
     snall intervals', which should in fact be 1 second. So is the PHY
     reporting link for a number of poll intervals? 1min to 10 minutes?

               Andrew

Yes, according to the log records, the phy polls every second,
but the link status changes take time.
Generally, it takes 10 seconds for the phy to detect link down,
but occasionally it takes several minutes to detect link down,
What PHY driver is this?

It is not so clear what should actually happen with auto-neg turned
off. With it on, and the link going down, the PHY should react after
about 1 second. It is not supposed to react faster than that, although
some PHYs allow fast link down notification to be configured.

Have you checked 802.3 to see what it says about auto-neg off and link
down detection?

I personally would not suppress this behaviour in the MAC
driver. Otherwise you are going to have funny combinations of special
cases of a feature which very few people actually use, making your
maintenance costs higher.

	    Andrew
Thanks for your suggestion, We are analyzing this issue in depth.



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux