On Fri, Jul 28, 2023 at 03:58:39PM +0800, Jijie Shao wrote: > From: Peiyang Wang <wangpeiyang1@xxxxxxxxxx> > > This patch will fix a wrong print "device link down/up". Consider a case > that set autoneg to off with same speed and duplex configuration. The link > is always up while the phy state is set to PHY_UP and set back to > PHY_RUNNING later. It will print link down when the phy state is not > PHY_RUNNING. To avoid that, the condition should include PHY_UP. Does this really happen? If autoneg is on, and there is link, it means the link peer is auto using auto-neg. If you turn auto-neg off, the link peer is not going to know what speed to use, and so the link will go down. The link will only come up again when you reconfigure the link peer to also not use auto-neg. I don't see how you can turn auto-neg off and not loose the link. Andrew
