On Mon, Oct 13, 2014 at 9:36 PM, Felipe Balbi <balbi@xxxxxx> wrote: > On Mon, Oct 13, 2014 at 02:26:32PM -0500, Felipe Balbi wrote: > I also noticed that this is missing: > > diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c > index e12e5b0..7db5ab9 100644 > --- a/drivers/pinctrl/pinctrl-baytrail.c > +++ b/drivers/pinctrl/pinctrl-baytrail.c > @@ -614,3 +614,9 @@ static int __init byt_gpio_init(void) > } > > subsys_initcall(byt_gpio_init); > + > +static void __exit byt_gpio_exit(void) > +{ > + platform_driver_unregister(&byt_gpio_driver); > +} > +module_exit(byt_gpio_exit); But the Baytrail driver is not a loadable module, it is bool: config PINCTRL_BAYTRAIL bool "Intel Baytrail GPIO pin control" depends on GPIOLIB && ACPI && X86 (...) So I guess it won't need handling for removal, as it can only be compiled-in. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html