On Thu, Jul 13, 2023 at 01:40:29PM +0200, Christoph Hellwig wrote: > Looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > one minor nitpick below: > > > if ((ia_valid & ATTR_MODE)) { > > + if (S_ISLNK(inode->i_mode)) > > + return -EOPNOTSUPP; > > Maybe some of the rationale on why we have this check from the commit > log should go here? I'll add a comment to the patch.