Re: [PATCH v2] attr: block mode changes of symlinks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

one minor nitpick below:

>  	if ((ia_valid & ATTR_MODE)) {
> +		if (S_ISLNK(inode->i_mode))
> +			return -EOPNOTSUPP;

Maybe some of the rationale on why we have this check from the commit
log should go here?




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux