On 19/06/2023 19.31, Robert Hancock wrote:
> On Mon, 2023-06-19 at 10:16 +0200, Rasmus Villemoes wrote:
>>
>> Fixes: 1fc33199185d ("net: dsa: microchip: Add PHY errata
>> workarounds")
>> Cc: stable@xxxxxxxxxxxxxxx
>> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
>> ---
>> While I do believe this is a fix, I don't think it's post-rc7
>> material, hence targeting net-next with cc stable.
>
> I don't think this will apply to net-next as the relevant code has been
> moved to the Micrel PHY driver and removed from this one in the
> following commits,
Ah, sorry about that. This code hadn't been touched in a very long time,
so I didn't actually think to check -next.
and effectively the same change to disable autoneg
> before the register writes and re-enable afterwards was incorporated:
Yes, except it seems to always enable autoneg, even if the phy was
strapped otherwise. That's not a problem for our use case.
> However, your patch may be reasonable to apply to -rc7 or stable as a
> more targeted change for those releases.
Well, yes, it could be backported, but then there'd be a (simple)
conflict when net-next is to be merged in the next window. So I don't
think it's worth it.
Unless the net maintainers decide otherwise, please just drop this patch.
Rasmus
