Hi,
On Sun, May 07, 2023 at 04:46:56PM +0200, Krzysztof Kozlowski wrote:
> The driver's probe() first registers regulators in a loop and then in a
> second loop passes them as irq data to the interrupt handlers. However
> the function to get the regulator for given name
> tps65219_get_rdev_by_name() was a no-op due to argument passed by value,
> not pointer, thus the second loop assigned always same value - from
> previous loop. The interrupts, when fired, where executed with wrong
> data. Compiler also noticed it:
>
> drivers/regulator/tps65219-regulator.c: In function ‘tps65219_get_rdev_by_name’:
> drivers/regulator/tps65219-regulator.c:292:60: error: parameter ‘dev’ set but not used [-Werror=unused-but-set-parameter]
>
> Fixes: c12ac5fc3e0a ("regulator: drivers: Add TI TPS65219 PMIC regulators support")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Reviewed-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx>
Best,
Markus
>
> ---
>
> Not tested.
> Sent two months ago and no comments, so resending.
>
> Cc: Jerome Neanne <jneanne@xxxxxxxxxxxx>
> Cc: khilman@xxxxxxxxxxxx
> Cc: msp@xxxxxxxxxxxx
> Cc: j-keerthy@xxxxxx
> ---
> drivers/regulator/tps65219-regulator.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/regulator/tps65219-regulator.c b/drivers/regulator/tps65219-regulator.c
> index b1719ee990ab..8971b507a79a 100644
> --- a/drivers/regulator/tps65219-regulator.c
> +++ b/drivers/regulator/tps65219-regulator.c
> @@ -289,13 +289,13 @@ static irqreturn_t tps65219_regulator_irq_handler(int irq, void *data)
>
> static int tps65219_get_rdev_by_name(const char *regulator_name,
> struct regulator_dev *rdevtbl[7],
> - struct regulator_dev *dev)
> + struct regulator_dev **dev)
> {
> int i;
>
> for (i = 0; i < ARRAY_SIZE(regulators); i++) {
> if (strcmp(regulator_name, regulators[i].name) == 0) {
> - dev = rdevtbl[i];
> + *dev = rdevtbl[i];
> return 0;
> }
> }
> @@ -348,7 +348,7 @@ static int tps65219_regulator_probe(struct platform_device *pdev)
> irq_data[i].dev = tps->dev;
> irq_data[i].type = irq_type;
>
> - tps65219_get_rdev_by_name(irq_type->regulator_name, rdevtbl, rdev);
> + tps65219_get_rdev_by_name(irq_type->regulator_name, rdevtbl, &rdev);
> if (IS_ERR(rdev)) {
> dev_err(tps->dev, "Failed to get rdev for %s\n",
> irq_type->regulator_name);
> --
> 2.34.1
>
