On Sat, Apr 22, 2023 at 05:05:08PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 18, 2023 at 03:01:21PM +0200, Uwe Kleine-König wrote:
> > On Tue, Apr 18, 2023 at 02:20:22PM +0200, Greg Kroah-Hartman wrote:
> > > From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > >
> > > [ Upstream commit 30006b77c7e130e01d1ab2148cc8abf73dfcc4bf ]
> > >
> > > The driver only supports normal polarity. Complete the implementation of
> > > .get_state() by setting .polarity accordingly.
> > >
> > > Reviewed-by: Guenter Roeck <groeck@xxxxxxxxxxxx>
> > > Fixes: 1f0d3bb02785 ("pwm: Add ChromeOS EC PWM driver")
> > > Link: https://lore.kernel.org/r/20230228135508.1798428-3-u.kleine-koenig@xxxxxxxxxxxxxx
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > > Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxx>
> > > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> >
> > I see you picked this one and the similar sprd patch, but not
> >
> > 8caa81eb950c pwm: meson: Explicitly set .polarity in .get_state()
> > b20b097128d9 pwm: iqs620a: Explicitly set .polarity in .get_state()
> > 6f5793798014 pwm: hibvt: Explicitly set .polarity in .get_state()
> >
> > (At least I didn't get a mail about these). These should qualify in the same way.
>
> They didn't all apply very well (one did).
Nope, that one broke the build, so none of these applied, which is
probably why Sasha didn't do it :)
thanks,
greg k-h
