RE: [PATCH 5.10 063/173] thunderbolt: Use const qualifier for `ring_interrupt_index`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[Public]

> On Tue, Apr 04, 2023 at 01:29:09PM +0200, Pavel Machek wrote:
> > Hi!
> >
> > > From: Mario Limonciello <mario.limonciello@xxxxxxx>
> > >
> > > commit 1716efdb07938bd6510e1127d02012799112c433 upstream.
> > >
> > > `ring_interrupt_index` doesn't change the data for `ring` so mark it as
> > > const. This is needed by the following patch that disables interrupt
> > > auto clear for rings.
> >
> > Yeah, nice cleanup. But do we really need it in -stable?
> 
> Yes, it was followed by a fix patch that needs this:
> 
> 468c49f44759 ("thunderbolt: Disable interrupt auto clear for rings")
> 
> I marked both for stable but perhaps the latter did not apply cleanly
> for v5.10?

468c49f44759 was a fix for 7a1808f82a37 which landed in 5.15-rc1.
The relevant AMD hardware w/ USB4 wasn't supported back in 5.10.

So no big reason to take this const qualifier patch in for 5.10 IMO.




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux