Re: [PATCH 5.10 063/173] thunderbolt: Use const qualifier for `ring_interrupt_index`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

> From: Mario Limonciello <mario.limonciello@xxxxxxx>
> 
> commit 1716efdb07938bd6510e1127d02012799112c433 upstream.
> 
> `ring_interrupt_index` doesn't change the data for `ring` so mark it as
> const. This is needed by the following patch that disables interrupt
> auto clear for rings.

Yeah, nice cleanup. But do we really need it in -stable?

Best regards,
								Pavel
								
> +++ b/drivers/thunderbolt/nhi.c
> @@ -36,7 +36,7 @@
>  
>  #define NHI_MAILBOX_TIMEOUT	500 /* ms */
>  
> -static int ring_interrupt_index(struct tb_ring *ring)
> +static int ring_interrupt_index(const struct tb_ring *ring)
>  {
>  	int bit = ring->hop;
>  	if (!ring->is_tx)
> 
> 

-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux