Re: [PATCH v2] mtd: spi-nor: spansion: Enable JFFS2 write buffer for Infineon SEMPER flash

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 04.04.2023 10:17, tkuw584924@xxxxxxxxx wrote:
> From: Takahiro Kuwano <Takahiro.Kuwano@xxxxxxxxxxxx>
> 
> Infineon(Cypress) SEMPER NOR flash family has on-die ECC and its program
> granularity is 16-byte ECC data unit size. JFFS2 supports write buffer
> mode for ECC'd NOR flash. To activate it, MTD_BIT_WRITEABLE needs to be
> unset in mtd->flags.
> 
> A new SNOR_F_ECC flag is introduced to determine if the part has on-die
> ECC and if it has, MTD_BIT_WRITEABLE is unset.
> 
> In vendor specific driver, a common cypress_nor_ecc_init() helper is
> added. This helper takes care for ECC related initialization for SEMPER
> flash family by setting up params->writesize and SNOR_F_ECC.
> 
> Fixes: 6afcc84080c4 ("mtd: spi-nor: spansion: Add support for Infineon S25FS256T")
> Fixes: b6b23833fc42 ("mtd: spi-nor: spansion: Add s25hl-t/s25hs-t IDs and fixups")
> Fixes: c3266af101f2 ("mtd: spi-nor: spansion: add support for Cypress Semper flash")

Would you please split this in 3 patches, first fixing c3266af101f2,
then b6b23833fc42 and then 6afcc84080c4? It will help stable team
backport each for each flash affected.

Looks good otherwise.



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux