Re: [PATCH] usb: dwc3: update link state when process wakeup interrupt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 02, 2023, Linyu Yuan wrote:
> 
> On 2/2/2023 3:05 AM, Thinh Nguyen wrote:
> > On Wed, Feb 01, 2023, Linyu Yuan wrote:
> > > Consider there is interrpt sequences as suspend (U3) -> wakeup (U0) ->
> > interrupt?
> 
> 
> thanks, will change next version.
> 
> 
> > 
> > > suspend (U3), as there is no update to link state in wakeup interrupt,
> > Instead of "no update", can you note in the commit that the link state
> > change event is not enabled for most devices, so the driver doesn't
> > update its link_state.
> 
> 
> thanks, will change next version.
> 
> 
> > 
> > > the second suspend interrupt will not report to upper layer.
> > > 
> > > Fix it by update link state in wakeup interrupt handler.
> > > 
> > > Cc: stable@xxxxxxxxxxxxxxx
> > Can you add fix tag?
> 
> 
> seem this change can apply to all current stable kernel.

Did we have handling of suspend/resume since the beginning? If we did,
please add a fix tag to the commit when the driver first added.

That helps to know that this is a fix patch.

Thanks,
Thinh

> 
> I think CC stable is good. also it is not good to find appreciate tag.
> 




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux