> -----Original Message----- > From: Jakub Kicinski <kuba@xxxxxxxxxx> > Sent: Thursday, February 2, 2023 2:38 PM > To: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > Cc: linux-hyperv@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; Dexuan Cui > <decui@xxxxxxxxxxxxx>; KY Srinivasan <kys@xxxxxxxxxxxxx>; Paul Rosswurm > <paulros@xxxxxxxxxxxxx>; olaf@xxxxxxxxx; vkuznets@xxxxxxxxxx; > davem@xxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx > Subject: Re: [PATCH net,v2] net: mana: Fix accessing freed irq affinity_hint > > On Wed, 1 Feb 2023 13:46:53 -0800 Haiyang Zhang wrote: > > + irq_set_affinity_and_hint(irq, > cpumask_of(cpumask_local_spread > > + (i, gc->numa_node))); > > The line break here looks ugly. > Please use a local variable for the mask or the cpu. Will do.