Toke Høiland-Jørgensen <toke@xxxxxxx> writes: > Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > >> On Sat, 2022-04-02 at 14:27 +0200, Toke Høiland-Jørgensen wrote: >>> >>> @@ -2591,12 +2602,6 @@ static void ath_tx_rc_status(struct ath_softc *sc, struct ath_buf *bf, >>> hw->max_rate_tries; >>> } >>> >>> - for (i = tx_rateindex + 1; i < hw->max_rates; i++) { >> >> might want to drop that blank line too :) >> >>> - tx_info->status.rates[i].count = 0; >>> - tx_info->status.rates[i].idx = -1; >>> - } >>> - >>> - tx_info->status.rates[tx_rateindex].count = ts->ts_longretry + 1; >>> } >> >> since there's nothing else. > > Hmm, fair point; Kalle, I don't suppose I could trouble you for a fixup > when committing? :) Sorry, editing the diff is more difficult for me. It would be easier if you could submit v2. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches