Re: [PATCH] MIPS: KVM: Fix memory leak on VCPU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 03, 2014 at 12:11:22PM -0700, Greg KH wrote:
> On Thu, Jul 03, 2014 at 09:53:40AM +0100, James Hogan wrote:
> > From: Deng-Cheng Zhu <dengcheng.zhu@xxxxxxxxxx>
> > 
> > Backport of commit 8c9eb041cf76038eb3b62ee259607eec9b89f48d.
> > 
> > kvm_arch_vcpu_free() is called in 2 code paths:
> > 
> > 1) kvm_vm_ioctl()
> >        kvm_vm_ioctl_create_vcpu()
> >            kvm_arch_vcpu_destroy()
> >                kvm_arch_vcpu_free()
> > 2) kvm_put_kvm()
> >        kvm_destroy_vm()
> >            kvm_arch_destroy_vm()
> >                kvm_mips_free_vcpus()
> >                    kvm_arch_vcpu_free()
> > 
> > Neither of the paths handles VCPU free. We need to do it in
> > kvm_arch_vcpu_free() corresponding to the memory allocation in
> > kvm_arch_vcpu_create().
> > 
> > Signed-off-by: Deng-Cheng Zhu <dengcheng.zhu@xxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> > Reviewed-by: James Hogan <james.hogan@xxxxxxxxxx>
> > Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> > [james.hogan@xxxxxxxxxx: Backported due to conflict without commit
> >  c6c0a6637f9d (MIPS: KVM: Remove redundant NULL checks before kfree())]
> 
> Ah, I just added this commit first, that way the backport would be
> identical to what is in Linus's tree, thanks.
> 
> greg k-h

Ah, great!  I'm queuing both patches for the 3.11 kernel as well.
Thank you.

Cheers,
--
Luís
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]