On Sat, 2014-06-14 at 07:51 -0700, James Bottomley wrote: > Upstream Commit: d555a2abf3481f81303d835046a5ec2c4fb3ca8e > > We unconditionally execute scsi_eh_get_sense() to make sure all failed > commands that should have sense attached, do. However, the routine forgets > that some commands, because of the way they fail, will not have any sense code > ... we should not bother them with a REQUEST_SENSE command. Fix this by > testing to see if we actually got a CHECK_CONDITION return and skip asking for > sense if we don't. > > Tested-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: James Bottomley <JBottomley@xxxxxxxxxxxxx> > > --- > > This actually fixes a bug in SCSI error handling (causing the eh to > issue a command while it is still pending at the HBA) which is causing > several other problems with miscellaneous drivers. Please backport as > far as it will go. Queued up for 3.2. The patch needed a context adjustment as there is no check for scsi_host_eh_past_deadline(). Ben. -- Ben Hutchings Any smoothly functioning technology is indistinguishable from a rigged demo.
Attachment:
signature.asc
Description: This is a digitally signed message part