Re: FAILED: patch "[PATCH] rtc: mc146818-lib: fix RTC presence check" failed to apply to 5.16-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



W dniu 24.01.2022 o 15:52, Greg KH pisze:
> On Mon, Jan 24, 2022 at 03:45:30PM +0100, Mateusz Jończyk wrote:
>> W dniu 24.01.2022 o 14:08, gregkh@xxxxxxxxxxxxxxxxxxx pisze:
>>> The patch below does not apply to the 5.16-stable tree.
>>> If someone wants it applied there, or to any other stable or longterm
>>> tree, then please email the backport, including the original git commit
>>> id to <stable@xxxxxxxxxxxxxxx>.
>>>
>>> thanks,
>>>
>>> greg k-h
>> Wait, this patch was not intended for submission into stable yet, at least not in this form.
>> Why did it end up in the stable queue?
> Because it was marked with a "Fixes:" tag and I reviewed it and it
> looked like it actually fixed an issue.
>
> Is this not the case?

Yes, that's correct. But I'm afraid that this patch will cause regressions on some systems.
(Mr Alexandre Belloni said something similar of my series). So I'd like to wait till at least Linux 5.17 (final) is
released to see if it causes any trouble.

>> The return values from mc146818_get_time() changed in between,
>> so it is natural that it does not apply.
>>
>> See
>> commit d35786b3a28dee20 ("rtc: mc146818-lib: change return values of mc146818_get_time()")
> Ok, so will a working backport be sent sometime in the future?
> thanks,
>
> greg k-h

Greetings,

Mateusz




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux