On 9/1/2021 4:36 PM, Jakub Kicinski wrote:
On Wed, 1 Sep 2021 10:21:55 -0700 Florian Fainelli wrote:
On 9/1/2021 2:21 AM, Rafał Miłecki wrote:
From: Rafał Miłecki <rafal@xxxxxxxxxx>
Setting DSA_MAX_PORTS caused DSA to call b53 callbacks (e.g.
b53_disable_port() during dsa_register_switch()) for invalid
(non-existent) ports. That made b53 modify unrelated registers and is
one of reasons for a broken BCM5301x support.
This problem exists for years but DSA_MAX_PORTS usage has changed few
times so it's hard to specify a single commit this change fixes.
You should still try to identify the relevant tags that this is fixing
such that this gets back ported to the appropriate trees. We could use
Fixes: 7e99e3470172 ("net: dsa: remove dsa_switch_alloc helper"), to
minimize the amount of work doing the back port.
To be clear are you okay with the fixes tag you provided or should we
wait for Rafał to double check?
That Fixes tag is correct and won't cause conflicts AFAICT with
backports all the way down to that commit.
--
Florian
