Re: Patch "x86,preempt: Fix preemption for i386" has been added to the 3.14-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 14, 2014 at 06:00:46PM +0200, Greg KH wrote:
> On Wed, May 14, 2014 at 03:30:18PM +0200, Peter Zijlstra wrote:
> > On Wed, May 14, 2014 at 05:40:50AM +0200, Greg KH wrote:
> > > Peter, Guenter is reporting that the patch below breaks all non-x86
> > > builds with:
> > > 
> > > include/asm-generic/preempt.h: In function '__preempt_count_dec_and_test':
> > > include/asm-generic/preempt.h:71:2: error: implicit declaration of function 'tif_need_resched' [-Werror=implicit-function-declaration]
> > >   return !--*preempt_count_ptr() && tif_need_resched();
> > > 
> > > Any ideas?
> > 
> > Yeah, I suck :/
> > 
> > Ok, the below seems to build on a number of !x86 archs and still does
> > build for i386 too.
> > 
> > Now its a little fragile, but since there's only a single
> > <asm/preempt.h> include (from linux/preempt.h) it should be safe.
> > 
> > Obviously its not actually been tested (as per the tags) because the
> > patch is different.
> 
> Thanks, I've applied this version, Gunter will let us know if it breaks
> anything else :)
> 

Everything is ok now.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]