On Thu, Feb 04, 2021 at 04:27:28PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Feb 04, 2021 at 03:12:52PM +0000, Catalin Marinas wrote:
> > On Thu, Feb 04, 2021 at 04:08:02PM +0100, Greg Kroah-Hartman wrote:
> > > On Wed, Feb 03, 2021 at 01:15:03PM +0000, Catalin Marinas wrote:
> > > > On Sun, Jan 31, 2021 at 03:40:58PM +0100, Greg Kroah-Hartman wrote:
> > > > > From 519ea6f1c82fcdc9842908155ae379de47818778 Mon Sep 17 00:00:00 2001
> > > > > From: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>
> > > > > Date: Tue, 26 Jan 2021 13:40:56 +0000
> > > > > Subject: [PATCH] arm64: Fix kernel address detection of __is_lm_address()
> > > > >
> > > > > Currently, the __is_lm_address() check just masks out the top 12 bits
> > > > > of the address, but if they are 0, it still yields a true result.
> > > > > This has as a side effect that virt_addr_valid() returns true even for
> > > > > invalid virtual addresses (e.g. 0x0).
> > > > >
> > > > > Fix the detection checking that it's actually a kernel address starting
> > > > > at PAGE_OFFSET.
> > > > >
> > > > > Fixes: 68dd8ef32162 ("arm64: memory: Fix virt_addr_valid() using __is_lm_address()")
> > > > > Cc: <stable@xxxxxxxxxxxxxxx> # 5.4.x
> > > > > Cc: Will Deacon <will@xxxxxxxxxx>
> > > > > Suggested-by: Catalin Marinas <catalin.marinas@xxxxxxx>
> > > > > Reviewed-by: Catalin Marinas <catalin.marinas@xxxxxxx>
> > > > > Acked-by: Mark Rutland <mark.rutland@xxxxxxx>
> > > > > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>
> > > > > Link: https://lore.kernel.org/r/20210126134056.45747-1-vincenzo.frascino@xxxxxxx
> > > > > Signed-off-by: Catalin Marinas <catalin.marinas@xxxxxxx>
> > > >
> > > > I sent you the 5.4 and 5.10 backports of this patch. There is another
> > > > fix in this area which I'll send to Linus tonight. It should apply
> > > > cleanly on 5.4 and 5.10.
> > >
> > > Both now applied. What is the git id of the other fix in Linus's tree?
> >
> > Thanks. The other commit is 91cb2c8b072e ("arm64: Do not pass tagged
> > addresses to __is_lm_address()").
>
> Great, grabbed that now too, thanks.
Thanks Greg.
--
Catalin
