On 11/13/20 5:58 AM, Salvatore Bonaccorso wrote: > Hi, > > On Thu, Nov 12, 2020 at 09:24:22AM -0800, Guenter Roeck wrote: >> On 11/12/20 9:21 AM, Naveen Krishna Chatradhi wrote: >>> This patch limits the visibility to owner and groups only for the >>> energy counters exposed through the hwmon based amd_energy driver. >>> >>> Cc: stable@xxxxxxxxxxxxxxx >>> Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >>> Signed-off-by: Naveen Krishna Chatradhi <nchatrad@xxxxxxx> >> >> This is very unusual, and may mess up the "sensors" command. >> What problem is this trying to solve ? > > Is this related to > > https://bugzilla.redhat.com/show_bug.cgi?id=1897402 > https://support.lenovo.com/lu/uk/product_security/LEN-50481 > https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-12912 > I guess so. The real fix would presumably be to read the power in the background. Of course, that won't work because reading it continuously or frequently causes power fluctuations. I'll apply the patch, but if there are complaints from users afterwards that "sensors" is broken I'll simply revert the entire driver. Guenter
