On 11/12/20 9:21 AM, Naveen Krishna Chatradhi wrote:
> This patch limits the visibility to owner and groups only for the
> energy counters exposed through the hwmon based amd_energy driver.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Naveen Krishna Chatradhi <nchatrad@xxxxxxx>
This is very unusual, and may mess up the "sensors" command.
What problem is this trying to solve ?
Guenter
> ---
> drivers/hwmon/amd_energy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/amd_energy.c b/drivers/hwmon/amd_energy.c
> index d06597303d5a..3197cda7bcd9 100644
> --- a/drivers/hwmon/amd_energy.c
> +++ b/drivers/hwmon/amd_energy.c
> @@ -171,7 +171,7 @@ static umode_t amd_energy_is_visible(const void *_data,
> enum hwmon_sensor_types type,
> u32 attr, int channel)
> {
> - return 0444;
> + return 0440;
> }
>
> static int energy_accumulator(void *p)
>
