Re: [PATCH] null_blk: Fix zone reset all tracing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 04, 2020 at 09:21:27AM +0000, Damien Le Moal wrote:
> On 2020/11/04 18:14, Greg Kroah-Hartman wrote:
> > On Wed, Nov 04, 2020 at 10:10:15AM +0100, Greg Kroah-Hartman wrote:
> >> On Wed, Nov 04, 2020 at 02:29:14PM +0900, Damien Le Moal wrote:
> >>> commit f9c9104288da543cd64f186f9e2fba389f415630 upstream.
> >>>
> >>> In the cae of the REQ_OP_ZONE_RESET_ALL operation, the command sector is
> >>> ignored and the operation is applied to all sequential zones. For these
> >>> commands, tracing the effect of the command using the command sector to
> >>> determine the target zone is thus incorrect.
> >>>
> >>> Fix null_zone_mgmt() zone condition tracing in the case of
> >>> REQ_OP_ZONE_RESET_ALL to apply tracing to all sequential zones that are
> >>> not already empty.
> >>>
> >>> Fixes: 766c3297d7e1 ("null_blk: add trace in null_blk_zoned.c")
> >>> Signed-off-by: Damien Le Moal <damien.lemoal@xxxxxxx>
> >>> Cc: stable@xxxxxxxxxxxxxxx
> >>> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
> >>> ---
> >>>  drivers/block/null_blk_zoned.c | 14 ++++++++------
> >>>  1 file changed, 8 insertions(+), 6 deletions(-)
> >>
> >> Now queued up, thanks.
> > 
> > Wait, no, I'll delay this one until the next round as it's not fixing
> > something introduced in this -rc series.
> 
> Yes, that problem is older.
> The lock fix I sent goes on top of this one though. I can send the backport for
> the lock fix without this patch applied. Is that OK ?

If the order of the patches is needed, then yes, I can take both, please
submit them as a patch series so that I know this is needed.

thanks,

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux